Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue 22804: multiple object files without linking produces broken files #13704

Merged
merged 2 commits into from
Feb 22, 2022

Conversation

ljmf00
Copy link
Member

@ljmf00 ljmf00 commented Feb 22, 2022

CC @rainers .

Signed-off-by: Luís Ferreira <contact@lsferreira.net>
@dlang-bot
Copy link
Contributor

Thanks for your pull request, @ljmf00!

Bugzilla references

Auto-close Bugzilla Severity Description
22804 regression [REG 2.099] compiling multiple files without linking produces broken object files

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "stable + dmd#13704"

…n files

Signed-off-by: Luís Ferreira <contact@lsferreira.net>
@ljmf00
Copy link
Member Author

ljmf00 commented Feb 22, 2022

Fixed line endings and used spaces instead of tabs for consistency.

@thewilsonator
Copy link
Contributor

@ljmf00 please merge when green.

@RazvanN7 RazvanN7 merged commit db53251 into dlang:stable Feb 22, 2022
@ljmf00
Copy link
Member Author

ljmf00 commented Feb 22, 2022

Now, I merge stable to master?

@thewilsonator
Copy link
Contributor

Merging stable into master can be done at any time by anyone.
As to whether it is necessary in this case: does the absence of this block other PRs to master? If yes or in doubt merge.
Otherwise its probably not necessary, but still harmless.

@MartinNowak MartinNowak mentioned this pull request Mar 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants