Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix Issue 21546 - covariant return checks for functions wrong if retu… #13722

Merged
merged 1 commit into from
Feb 26, 2022

Conversation

WalterBright
Copy link
Member

…rning by ref

This is an ugly problem. How did it go undetected this long?

@dlang-bot
Copy link
Contributor

Thanks for your pull request, @WalterBright!

Bugzilla references

Auto-close Bugzilla Severity Description
21546 critical covariant return checks for functions wrong if returning by ref

⚠️⚠️⚠️ Warnings ⚠️⚠️⚠️

To target stable perform these two steps:

  1. Rebase your branch to upstream/stable:
git rebase --onto upstream/stable upstream/master
  1. Change the base branch of your PR to stable

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#13722"

@WalterBright
Copy link
Member Author

This fix may break existing code, so I'm not going to target stable with it.

@dlang-bot dlang-bot merged commit acb74fd into dlang:master Feb 26, 2022
@WalterBright WalterBright deleted the fix21546 branch February 26, 2022 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants