fix Issue 22812 - ImportC: C11 does not allow newlines between the start and end of a directive

[ibuclaw]

Fix is identical to #13727, but fixes parsing in pragmaPack instead of poundLine.

[dlang-bot]

Thanks for your pull request, @ibuclaw!

Bugzilla references

Auto-close	Bugzilla	Severity	Description
✓	22812	normal	ImportC: C11 does not allow newlines between the start and end of a directive
✓	22825	normal	#line parsing doesn't follow the spec

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#13728"

[WalterBright]

see my comments

Addressed.

[ibuclaw]

@WalterBright as you can see from all the errors, unsetting tokenizeNewlines at the point where a newline is seen doesn't work as-is.

==============================
Test 'fail_compilation/test21008.d' failed: 
expected:
----
fail_compilation/test21008.d(110): Error: function `test21008.C.after` circular reference to class `C`
fail_compilation/test21008.d(117): Error: need `this` for `toString` of type `string()`
fail_compilation/test21008.d(117): Error: need `this` for `toHash` of type `nothrow @trusted $?:32=uint|64=ulong$()`
fail_compilation/test21008.d(117): Error: function `object.Object.opCmp(Object o)` is not callable using argument types `()`
fail_compilation/test21008.d(117):        missing argument for parameter #1: `Object o`
fail_compilation/test21008.d(117): Error: function `object.Object.opEquals(Object o)` is not callable using argument types `()`
fail_compilation/test21008.d(117):        missing argument for parameter #1: `Object o`
fail_compilation/test21008.d(117): Error: `Monitor` has no effect
fail_compilation/test21008.d(117): Error: function `object.Object.factory(string classname)` is not callable using argument types `()`
fail_compilation/test21008.d(117):        missing argument for parameter #1: `string classname`
fail_compilation/test21008.d(105):        called from here: `handleMiddlewareAnnotation()`
fail_compilation/test21008.d(108): Error: class `test21008.C` no size because of forward reference
----
actual:
----
fail_compilation/test21008.d(99): Error: declaration expected, not `\n`
fail_compilation/test21008.d(106): Error: unmatched closing brace
----

[ibuclaw]

Adapted poundLine() to call scan() to get each token in a #line directive.

The scope(exit) remains as it still is needed to catch the error case when parsing a special token sequence.

[ibuclaw]

scope(exit) has been removed.

Ping @WalterBright

[ibuclaw]

scope(exit) has been removed.

Ping @WalterBright

[dkorpel]

dwt ~master: building configuration "linux-gtk"...
base/src/java/nonstandard/UnsafeUtf.d-mixin-12(13,1): Error: undefined escape hex sequence \Ut

I don't see how this PR leads to that buildkite failure.

[ibuclaw]

dwt ~master: building configuration "linux-gtk"...
base/src/java/nonstandard/UnsafeUtf.d-mixin-12(13,1): Error: undefined escape hex sequence \Ut

I don't see how this PR leads to that buildkite failure.

The spec needs changing: dlang/dlang.org#3257.

DWT has been fixed: d-widget-toolkit/dwt#107

[ljmf00]

This introduced trailing whitespace. Fix: #13863