Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Issue 21975 - is expression ignores implicit conversion of struct via alias this when pattern matching #13738

Merged
merged 1 commit into from
Mar 1, 2022

Conversation

RazvanN7
Copy link
Contributor

@RazvanN7 RazvanN7 commented Mar 1, 2022

The issue was that when the template types are deduced, implicit conversions were not taken into account. This worked for classes because it would not return immediately upon a no match [1]. I made use of the same check to fix this.

[1] https://github.com/dlang/dmd/blob/master/src/dmd/dtemplate.d#L4436

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @RazvanN7! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
21975 normal is expression ignores implicit conversion of struct via alias this when pattern matching

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#13738"

@dlang-bot dlang-bot merged commit 5572f7c into dlang:master Mar 1, 2022
@pbackus
Copy link
Contributor

pbackus commented Mar 1, 2022

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants