-
-
Notifications
You must be signed in to change notification settings - Fork 610
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issue 22837 - checkConstructorEscape quits after first non-pointer #13744
Conversation
|
Thanks for your pull request and interest in making D better, @dkorpel! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please see CONTRIBUTING.md for more information. If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment. Bugzilla references
Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "master + dmd#13744" |
|
Depends on dlang/phobos#8398 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No description provided.
test/fail_compilation/test19097.d
Outdated
| @@ -1,7 +1,8 @@ | |||
| /* REQUIRED_ARGS: -preview=dip1000 | |||
| * TEST_OUTPUT: | |||
| --- | |||
| fail_compilation/test19097.d(35): Error: scope variable `s` may not be returned | |||
| fail_compilation/test19097.d(36): Error: scope variable `s` may not be returned | |||
| fail_compilation/test19097.d(74): Error: scope variable `s` may not be returned | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this error refer to s.i instead of s?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
escape.d likes to reduce expressions to 'the variable it really is', so s.x => s, or sarray[0] => sarray etc. This is reflected in the error messages.
292ec26 to
f374ee4
Compare
f374ee4 to
54ecdf4
Compare
No description provided.