Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue 22837 - checkConstructorEscape quits after first non-pointer #13744

Merged
merged 1 commit into from
Mar 4, 2022

Conversation

dkorpel
Copy link
Contributor

@dkorpel dkorpel commented Mar 2, 2022

No description provided.

@dkorpel dkorpel added the dip1000 memory safety with scope, ref, return label Mar 2, 2022
@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @dkorpel! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
22837 normal [dip1000] checkConstructorEscape quits after first non-pointer

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#13744"

@dkorpel
Copy link
Contributor Author

dkorpel commented Mar 2, 2022

Depends on dlang/phobos#8398

Copy link
Contributor

@MoonlightSentinel MoonlightSentinel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No description provided.

@@ -1,7 +1,8 @@
/* REQUIRED_ARGS: -preview=dip1000
* TEST_OUTPUT:
---
fail_compilation/test19097.d(35): Error: scope variable `s` may not be returned
fail_compilation/test19097.d(36): Error: scope variable `s` may not be returned
fail_compilation/test19097.d(74): Error: scope variable `s` may not be returned
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this error refer to s.i instead of s?

Copy link
Contributor Author

@dkorpel dkorpel Mar 2, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

escape.d likes to reduce expressions to 'the variable it really is', so s.x => s, or sarray[0] => sarray etc. This is reflected in the error messages.

@dkorpel dkorpel force-pushed the extended-return-miss branch from 292ec26 to f374ee4 Compare March 2, 2022 17:38
@dkorpel dkorpel force-pushed the extended-return-miss branch from f374ee4 to 54ecdf4 Compare March 4, 2022 09:27
@dkorpel dkorpel merged commit 925f527 into dlang:master Mar 4, 2022
@dkorpel dkorpel deleted the extended-return-miss branch March 4, 2022 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dip1000 memory safety with scope, ref, return Severity:Bug Fix
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants