Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Issue 21844: makedeps contain non-existing files #13755

Merged
merged 1 commit into from
Mar 5, 2022

Conversation

Panke
Copy link

@Panke Panke commented Mar 4, 2022

There is no reasonable way to track non-existing files (since they could be anywhere where -J, -I points to) and by not tracking them at least the builds won't be always out of date.

@dlang-bot
Copy link
Contributor

dlang-bot commented Mar 4, 2022

Thanks for your pull request and interest in making D better, @Panke! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
21844 major makedeps option adds spurious/incorrect dependency

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "stable + dmd#13755"

@kinke
Copy link
Contributor

kinke commented Mar 4, 2022

LGTM, thanks! - I consider this a mjaor issue, not a minor one, and would suggest targeting stable, so that it can still make it into v2.099.0.

@Panke Panke changed the base branch from master to stable March 4, 2022 14:32
@Panke
Copy link
Author

Panke commented Mar 4, 2022

Rebased onto stable

@ljmf00
Copy link
Member

ljmf00 commented Mar 4, 2022

I changed the issue's importance. Buildkite is failing, perhaps due to changing the target branch. Can you force amend the commit and push?

@dlang-bot dlang-bot merged commit 24aa1e7 into dlang:stable Mar 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants