replace Dsymbol.comment with hash table #13769
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request, @WalterBright! Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "master + dmd#13769" |
WalterBright
force-pushed
the
DsymbolComment
branch
2 times, most recently
from
e1295ac
to
16f90c0
Compare
MoonlightSentinel
previously requested changes
Mar 5, 2022
WalterBright
force-pushed
the
DsymbolComment
branch
3 times, most recently
from
07920e8
to
e4ca330
Compare
How was this tested? IIRC, comment is a dead field unless you are building ddoc. So that might dramatically swing the usage of it. That is not to say however that default disabled behaviours should occupy space in the AST. I agree with the assessment that this is a superfluous field. |
ibuclaw
reviewed
Mar 6, 2022
WalterBright
force-pushed
the
DsymbolComment
branch
from
e4ca330
to
6a4e0eb
Compare
RazvanN7
approved these changes
Mar 7, 2022
|
This PR introduced a regression. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
since according to #13762 it is 99.97% unused.