-
-
Notifications
You must be signed in to change notification settings - Fork 610
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issue 22863 - -main doesn't work anymore when used for linking only #13830
Conversation
|
Thanks for your pull request and interest in making D better, @dkorpel! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please see CONTRIBUTING.md for more information. If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment. Bugzilla references
Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "stable + dmd#13830" |
src/dmd/mars.d
Outdated
| if (!params.oneobj) | ||
| params.objfiles.push(mainModule.objfile.toChars()); | ||
| else if (modules.length == 1) | ||
| params.objfiles.insert(0, mainModule.objfile.toChars()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Inserting at position 0 is just an LDC specificum for -singleobj, DMD shouldn't need it and probably just append it, as for the !oneobj case.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are some .debug_ranges conflicts on debug info for -main generated functions. Perhaps, is this somewhat related?
befcc75 to
3b1bce2
Compare
b26f171 to
76c3836
Compare
|
circleci: Not sure why it's not deleted, dmd gets passed |
|
|
|
I'll defer to @kinke on this one. -Walter |
Porting ldc-developers/ldc#3938 to DMD