Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 22898 - [REG master] Solaris: byte.min value is 128 #13834

Merged
merged 1 commit into from
Mar 19, 2022

Conversation

ibuclaw
Copy link
Member

@ibuclaw ibuclaw commented Mar 18, 2022

C char can either be signed or unsigned, depending on platform (or in some cases, compiler flags).

@dlang-bot
Copy link
Contributor

Thanks for your pull request, @ibuclaw!

Bugzilla references

Auto-close Bugzilla Severity Description
22898 regression [REG master] Solaris: byte.min value is 128

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#13834"

@thewilsonator
Copy link
Contributor

Does this fix the issue? if so please update the committee message to reflect that.

@ibuclaw
Copy link
Member Author

ibuclaw commented Mar 19, 2022

Does this fix the issue? if so please update the committee message to reflect that.

No, because druntime still has alias int8_t = char.

@dlang-bot dlang-bot merged commit 18474e2 into dlang:master Mar 19, 2022
@ibuclaw ibuclaw deleted the issue22898 branch March 19, 2022 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants