Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue 22910 - return scope struct member functions allow returning this by ref #13860

Merged
merged 1 commit into from
Mar 23, 2022

Conversation

dkorpel
Copy link
Contributor

@dkorpel dkorpel commented Mar 22, 2022

Following up #13693
Blocked by: dlang/druntime#3782 dlang/phobos#8416
The supplemental error is not right, but that's a separate issue.

@dkorpel dkorpel added Merge:Blocked dip1000 memory safety with scope, ref, return labels Mar 22, 2022
@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @dkorpel! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
22910 normal [dip1000] return scope struct member functions allow returning `this` by ref

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#13860"

@dkorpel dkorpel force-pushed the return-scope-this branch from 5d76d0c to 31f410b Compare March 23, 2022 10:02
@dkorpel
Copy link
Contributor Author

dkorpel commented Mar 23, 2022

It's unblocked now

Copy link
Contributor

@RazvanN7 RazvanN7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we issue a deprecation for this? Or do we consider that dip1000 is experimental and therefore breaking changes are allowed?

@dkorpel
Copy link
Contributor Author

dkorpel commented Mar 23, 2022

Or do we consider that dip1000 is experimental and therefore breaking changes are allowed?

Code behind a -preview switch may break is the policy: #13691 (comment)

This PR is no different than any of the previous 'accepts invalid' fixes of dip1000 in that regard.

@RazvanN7 RazvanN7 merged commit 6eb65bb into dlang:master Mar 23, 2022
@dkorpel dkorpel deleted the return-scope-this branch March 23, 2022 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dip1000 memory safety with scope, ref, return Severity:Bug Fix
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants