Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 22915 - Print the type of invalid foreach aggregates #13877

Merged
merged 1 commit into from
Mar 24, 2022

Conversation

MoonlightSentinel
Copy link
Contributor

Mentioning the type alongside the expressions is helpful when the
error isn't obvious, e.g. when the code didn't derefence a pointer.

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @MoonlightSentinel! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
22915 minor Errors for invalid foreach aggregates should print the type

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#13877"

src/dmd/statementsem.d Outdated Show resolved Hide resolved
Mentioning the type alongside the expressions is helpful when the
error isn't obvious, e.g. when the code didn't derefence a pointer.
@Geod24 Geod24 merged commit 11f7f63 into dlang:master Mar 24, 2022
@MoonlightSentinel MoonlightSentinel deleted the foreach-error branch March 24, 2022 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants