Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix Issue 22913 - importC: array index expression parsed as cast #13880

Merged
merged 1 commit into from
Mar 25, 2022
Merged

fix Issue 22913 - importC: array index expression parsed as cast #13880

merged 1 commit into from
Mar 25, 2022

Conversation

WalterBright
Copy link
Member

No description provided.

@WalterBright WalterBright added the Feature:ImportC Pertaining to ImportC support label Mar 24, 2022
@WalterBright WalterBright requested a review from ibuclaw as a code owner March 24, 2022 04:12
@dlang-bot
Copy link
Contributor

dlang-bot commented Mar 24, 2022 •
edited
Loading

Thanks for your pull request, @WalterBright!

Bugzilla references

Auto-close Bugzilla Severity Description
✓ 22913 regression importC: array index expression parsed as cast

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#13880"

@RazvanN7
Copy link
Contributor

This should target stable.

@WalterBright
Copy link
Member Author

I don't think so, because the cause of the regression is not in stable.

@ljmf00
Copy link
Member

ljmf00 commented Mar 24, 2022

I don't think so, because the cause of the regression is not in stable.

So, is it really a regression in the user perspective? I had the idea that regression is only applied to tagged versions.

@WalterBright
Copy link
Member Author

That's right.

@RazvanN7 RazvanN7 merged commit 0e3e0f9 into dlang:master Mar 25, 2022
@WalterBright WalterBright deleted the fix22913 branch March 25, 2022 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RazvanN7 RazvanN7 RazvanN7 approved these changes

@ibuclaw ibuclaw Awaiting requested review from ibuclaw ibuclaw is a code owner

Assignees
No one assigned
Labels
Feature:ImportC Pertaining to ImportC support Severity:Bug Fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@WalterBright @dlang-bot @RazvanN7 @ljmf00