-
-
Notifications
You must be signed in to change notification settings - Fork 610
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix 22934 - Emit context pointer as outer instead of this
#13887
Conversation
|
Thanks for your pull request and interest in making D better, @MoonlightSentinel! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please see CONTRIBUTING.md for more information. If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment. Bugzilla references
Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "master + dmd#13887" |
4bdef64 to
9c4dc43
Compare
this instead of thisthis instead of outer
|
Fixed the typo in the commit title |
9c4dc43 to
689b092
Compare
this instead of outerouter instead of this
| @@ -116,7 +116,7 @@ public: | |||
| { | |||
| public: | |||
| int32_t x; | |||
| A* this; | |||
| A* outer; | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can it be emitted as private?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure but why? The outer property isn't private in D.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will break the dtoh end-user API. Probably we should add a changelog entry explaining it.
|
How so? Any header affected by this change wasn't compilable anyways ( |
2421156 to
7a555d2
Compare
Changelog added, also this fixes an emits invalid
7a555d2 to
cd1017c
Compare
Because the latter is obviosly not a valid identifier.
Because the latter is obviosly not a valid identifier.