Fix Issue 22919 - -checkaction=context gives "assigned to `__assertOp…

[dkorpel]

…2` with longer lifetime"

The problem is that the __assertOp2 is a temporary with the ref storage class, which is assumed to have longer lifetime than any local. One fix is to add an exception for a va with STC.temp, but the whole thing starts to look rather redundant when there's also vaIsRef, so let's see if we can remove it.

[dlang-bot]

Thanks for your pull request and interest in making D better, @dkorpel! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

• My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
• My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
• I have provided a detailed rationale explaining my changes
• New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.

---

If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close	Bugzilla	Severity	Description
✓	22919	normal	[dip1000] -checkaction=context gives "assigned to `__assertOp2` with longer lifetime"

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#13888"

[thewilsonator]

Please rebase to pick up the fix for the OSX CIs.