Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Issue 22945 - [Conditional Compilation] support invariant version flag #13896

Merged
merged 5 commits into from
Mar 28, 2022
Merged

Fix Issue 22945 - [Conditional Compilation] support invariant version flag #13896

merged 5 commits into from
Mar 28, 2022

Conversation

iK4tsu
Copy link
Contributor

@iK4tsu iK4tsu commented Mar 27, 2022

This is a follow-up from https://issues.dlang.org/show_bug.cgi?id=22278
I advise reading the context of this PR: #13048
Sorry for taking so long to add this.

iK4tsu added 3 commits March 27, 2022 12:33
@iK4tsu
feat(mars): add version condition D_Invariants
ffd4bea 
Signed-off-by: João Lourenço <jlourenco5691@gmail.com>
@iK4tsu
test(reserved_version): test version condition D_Invariant
23b7d68 
Signed-off-by: João Lourenço <jlourenco5691@gmail.com>
@iK4tsu
test(reserved_version_switch): test version condition D_Invariant
969ca20 
Signed-off-by: João Lourenço <jlourenco5691@gmail.com>
@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @iK4tsu! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.

If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
✓ 22945 enhancement [Conditional Compilation] support invariant version flag

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#13896"

thewilsonator
thewilsonator requested changes Mar 27, 2022
View reviewed changes
Copy link
Contributor

@thewilsonator thewilsonator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a changelog entry and possibly spec update.

@thewilsonator thewilsonator added the Review:Needs Changelog A changelog entry needs to be added to /changelog label Mar 27, 2022
@ljmf00 ljmf00 added the Review:Needs Spec PR A PR updating the language specification needs to be submitted to dlang.org label Mar 27, 2022
ljmf00
ljmf00 requested changes Mar 27, 2022
View reviewed changes
test/runnable/test22945.d Outdated Show resolved Hide resolved
test/runnable/test22945.d Outdated Show resolved Hide resolved
@iK4tsu iK4tsu mentioned this pull request Mar 27, 2022
Merged
@iK4tsu iK4tsu force-pushed the feat-invariant-flag branch from d05b306 to 76161e6 Compare March 27, 2022 15:46
@iK4tsu
Copy link
Contributor Author

iK4tsu commented Mar 27, 2022

Needs a changelog entry and possibly spec update.

Spec PR ready, but what is the changelog entry thing? Never had to do one of those.

@iK4tsu
test(runnable): add runnable tests for version condition D_Invariant
e61b33c 
FIX ISSUE 22945

Signed-off-by: João Lourenço <jlourenco5691@gmail.com>
@iK4tsu iK4tsu force-pushed the feat-invariant-flag branch from 76161e6 to e61b33c Compare March 27, 2022 16:16
@ljmf00 ljmf00 removed the Review:Needs Spec PR A PR updating the language specification needs to be submitted to dlang.org label Mar 27, 2022
@dkorpel
Copy link
Contributor

dkorpel commented Mar 27, 2022

Spec PR ready, but what is the changelog entry thing? Never had to do one of those.

Since it closes a bugzilla issue a changelog entry is not required, but it could be nice. See https://github.com/dlang/dmd/tree/master/changelog

@iK4tsu
Copy link
Contributor Author

iK4tsu commented Mar 27, 2022

Oh I see, it's better if I do it in a separate PR right?

@dkorpel
Copy link
Contributor

dkorpel commented Mar 27, 2022

it's better if I do it in a separate PR right?

No, it's usually done in the same PR

@iK4tsu
chore(changelog): add a more in-depth preview of the version conditio…
ce6d3be 
…n D_Invariant feature

Signed-off-by: João Lourenço <jlourenco5691@gmail.com>
@iK4tsu
Copy link
Contributor Author

iK4tsu commented Mar 27, 2022

Added changelog entry

@ljmf00 ljmf00 removed the Review:Needs Changelog A changelog entry needs to be added to /changelog label Mar 27, 2022
@ljmf00 ljmf00 requested a review from thewilsonator March 27, 2022 18:10
@thewilsonator thewilsonator merged commit 8afba50 into dlang:master Mar 28, 2022
@iK4tsu iK4tsu deleted the feat-invariant-flag branch March 29, 2022 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dkorpel dkorpel dkorpel approved these changes

@thewilsonator thewilsonator thewilsonator approved these changes

@ljmf00 ljmf00 ljmf00 approved these changes

@MartinNowak MartinNowak Awaiting requested review from MartinNowak MartinNowak is a code owner

@Geod24 Geod24 Awaiting requested review from Geod24 Geod24 is a code owner

@rainers rainers Awaiting requested review from rainers rainers is a code owner

@UplinkCoder UplinkCoder Awaiting requested review from UplinkCoder UplinkCoder is a code owner

@WalterBright WalterBright Awaiting requested review from WalterBright WalterBright is a code owner

Assignees
No one assigned
Labels
Merge:auto-merge Severity:Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@iK4tsu @dlang-bot @dkorpel @ljmf00 @thewilsonator