fix Issue 22931 - importC: Error: 0 has no effect #13912
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WalterBright
added
Review:Easy Review
Feature:ImportC
|
Thanks for your pull request, @WalterBright! Bugzilla references
Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "master + dmd#13912" |
dkorpel
approved these changes
Mar 29, 2022
RazvanN7
reviewed
Mar 29, 2022
| if (e.type is Type.tvoid) | ||
| discardValue(e.e1); | ||
| else if (!e.allowCommaExp && !e.isGenerated && !(sc.flags & SCOPE.Cfile)) | ||
| else if (!e.allowCommaExp && !e.isGenerated) | ||
| e.error("Using the result of a comma expression is not allowed"); |
There was a problem hiding this comment.
This is unrelated to this PR, but shouldn't result be pointing to an ErrorExp in this case?
There was a problem hiding this comment.
You're probably right. But that should be a separate PR.
|
@ibuclaw it isn't in ImportC's mission to do warnings. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.