Fix 22951 - Emit non-extern (C++) destructors as private members #13914
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Destructors not marked as
extern (C++)aren't accessible from C++due to the D name mangling. The header generator used to skip
extern(D)destructors, allowing C++ code that violated RAII guarantees.
Declaring the constructors as
privatemembers ensures that anyinstance that would need to be destroyed on the C++ side causes a
compiler error (rather than a linker error due to missmatched mangling).
Renamed the helper function
checkVirtualFunctionbecause it now alsohandles other types of functions.