Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 22951 - Emit non-extern (C++) destructors as private members #13914

Merged
merged 1 commit into from
Mar 29, 2022

Conversation

MoonlightSentinel
Copy link
Contributor

Destructors not marked as extern (C++) aren't accessible from C++
due to the D name mangling. The header generator used to skip extern(D)
destructors, allowing C++ code that violated RAII guarantees.

Declaring the constructors as private members ensures that any
instance that would need to be destroyed on the C++ side causes a
compiler error (rather than a linker error due to missmatched mangling).

Renamed the helper function checkVirtualFunction because it now also
handles other types of functions.

@MoonlightSentinel MoonlightSentinel added the Feature:dtoh C++ header generation label Mar 29, 2022
@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @MoonlightSentinel! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
22951 normal Dtor missing from generated C++ header

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#13914"

@dlang-bot dlang-bot merged commit 3b20c1d into dlang:master Mar 29, 2022
Destructors not marked as `extern (C++)` aren't accessible from C++
due to the D name mangling. The header generator used to skip `extern(D)`
destructors, allowing C++ code that violated RAII guarantees.

Declaring the constructors as `private` members ensures that any
instance that would need to be destroyed on the C++ side causes a
compiler error (rather than a linker error due to missmatched mangling).

Renamed the helper function `checkVirtualFunction` because it now also
handles other types of functions.
@MoonlightSentinel MoonlightSentinel deleted the dtoh/dtor-dummy branch March 29, 2022 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants