Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 22954 - dtoh: Ignore member functions with C linkage #13915

Merged
merged 1 commit into from
Mar 29, 2022

Conversation

MoonlightSentinel
Copy link
Contributor

Those functions receive D mangling and hence aren't easily callable via
the header file. Note that C++ does the same for members in an
extern "C" aggregate (=> mangle as C++ symbol).
`

@MoonlightSentinel MoonlightSentinel added the Feature:dtoh C++ header generation label Mar 29, 2022
@dlang-bot
Copy link
Contributor

dlang-bot commented Mar 29, 2022

Thanks for your pull request and interest in making D better, @MoonlightSentinel! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
22954 normal Header generator emits extern(C) member functions

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#13915"

Copy link
Contributor

@dkorpel dkorpel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this also ignore extern(C) functions mixed in at global scope?
Edit: For clarity, I mean with a template mixin, not a string mixin.

@MoonlightSentinel MoonlightSentinel changed the title Fix - dtoh: Ignore member functions with C linkage Fix 22954 - dtoh: Ignore member functions with C linkage Mar 29, 2022
@MoonlightSentinel
Copy link
Contributor Author

No. I've added an example to the dshell test.

@dlang-bot dlang-bot merged commit 15ecd8c into dlang:master Mar 29, 2022
Those functions receive D mangling and hence aren't easily callable via
the header file. Note that C++ does the same for members in an
`extern "C"` aggregate (=> mangle as C++ symbol).
`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants