-
-
Notifications
You must be signed in to change notification settings - Fork 610
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix 22954 - dtoh: Ignore member functions with C linkage #13915
Fix 22954 - dtoh: Ignore member functions with C linkage #13915
Conversation
|
Thanks for your pull request and interest in making D better, @MoonlightSentinel! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please see CONTRIBUTING.md for more information. If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment. Bugzilla references
Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "master + dmd#13915" |
c52bd9d to
98fd078
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this also ignore extern(C) functions mixed in at global scope?
Edit: For clarity, I mean with a template mixin, not a string mixin.
98fd078 to
29d1c5a
Compare
|
No. I've added an example to the dshell test. |
Those functions receive D mangling and hence aren't easily callable via the header file. Note that C++ does the same for members in an `extern "C"` aggregate (=> mangle as C++ symbol). `
Those functions receive D mangling and hence aren't easily callable via
the header file. Note that C++ does the same for members in an
extern "C"aggregate (=> mangle as C++ symbol).`