fix Issue 22935 - importC: offsetof with array element gives 'derefer… #13925
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request, @WalterBright! Bugzilla references
Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "master + dmd#13925" |
dkorpel
reviewed
Mar 30, 2022
src/dmd/optimize.d
Outdated
|
|
||
| import core.checkedint : mulu; | ||
| bool overflow; | ||
| const offset = mulu(index, ts.nextOf().size(e.loc), overflow); |
There was a problem hiding this comment.
D-scanner doesn't like this unused variable
dkorpel
previously requested changes
Mar 30, 2022
WalterBright
force-pushed
the
fix22935
branch
2 times, most recently
from
c1929c1 to
b748fe9
Compare
…ence of invalid pointer'
RazvanN7
approved these changes
Mar 31, 2022
|
Appears to cause https://issues.dlang.org/show_bug.cgi?id=22976 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ence of invalid pointer'
Could use a refactoring to eliminate some copy/pasta, but that's best left to a followup.