Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Issue 22801 - [master] Can't return address of return ref parameter from constructor #13940

Merged
merged 1 commit into from
Apr 1, 2022

Conversation

dkorpel
Copy link
Contributor

@dkorpel dkorpel commented Apr 1, 2022

Same as #13699, but targeting master. It seems like this depends on the return-ref-scope ambiguity fixes that aren't in stable yet.

@dkorpel dkorpel added Review:WIP Work In Progress - not ready for review or pulling dip1000 memory safety with scope, ref, return labels Apr 1, 2022
@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @dkorpel! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
22801 regression [REG 2.099.0-beta.1] Can't return address of return ref parameter from constructor

⚠️⚠️⚠️ Warnings ⚠️⚠️⚠️

To target stable perform these two steps:

  1. Rebase your branch to upstream/stable:
git rebase --onto upstream/stable upstream/master
  1. Change the base branch of your PR to stable

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#13940"

@dkorpel dkorpel removed the Review:WIP Work In Progress - not ready for review or pulling label Apr 1, 2022
@dkorpel dkorpel marked this pull request as ready for review April 1, 2022 13:22
@dkorpel
Copy link
Contributor Author

dkorpel commented Apr 1, 2022

@RazvanN7 I think it's okay to merge this into master:

  • it's not really a regression, escape analysis was never done when assigning the address of a ref parameter to this, so allowing it before was a hole
  • dip1000 is still behind a preview switch
  • it depends on other dip1000 fixes which are in master

@RazvanN7 RazvanN7 merged commit 30f4a32 into dlang:master Apr 1, 2022
@dkorpel dkorpel deleted the ref-assign-regression1 branch April 1, 2022 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dip1000 memory safety with scope, ref, return Severity:Bug Fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants