Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Issue 12344 - .di generation doesn't include contracts in interfaces #13943

Merged
merged 1 commit into from
Apr 7, 2022

Conversation

dkorpel
Copy link
Contributor

@dkorpel dkorpel commented Apr 3, 2022

No description provided.

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @dkorpel! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
12344 normal .di generation doesn't include contracts in interfaces

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#13943"

@dkorpel dkorpel marked this pull request as draft April 3, 2022 14:22
@dkorpel dkorpel force-pushed the di-contract branch 3 times, most recently from 0154eca to e226db4 Compare April 3, 2022 15:12
@dkorpel
Copy link
Contributor Author

dkorpel commented Apr 3, 2022

I need to figure out what's the difference between header1.di and header1i.di and whether it's right that contracts are not emitted in the latter.

@dkorpel dkorpel marked this pull request as ready for review April 6, 2022 08:42
@dkorpel
Copy link
Contributor Author

dkorpel commented Apr 6, 2022

Turns out -inline sets global.params.hdrStripPlainFunctions to false, and bodyToBuffer doesn't output contracts for bodyless functions ever. I changed it so it does.

@dlang-bot dlang-bot merged commit c1b9938 into dlang:master Apr 7, 2022
@dkorpel dkorpel deleted the di-contract branch April 7, 2022 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants