fix Issue 22974 - importC: D name mangling applied to extern variable… #13950
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WalterBright
added
Review:Easy Review
Feature:ImportC
|
Thanks for your pull request, @WalterBright! Bugzilla references
Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "master + dmd#13950" |
WalterBright
force-pushed
the
fix22974
branch
2 times, most recently
from
d8d803f to
ce82e5f
Compare
The file |
dkorpel
reviewed
Apr 5, 2022
dkorpel
approved these changes
Apr 5, 2022
ghost
reviewed
Apr 6, 2022
test/runnable/test22974.c
Outdated
| extern int ccc(); | ||
| extern int xxx; | ||
| xxx = ccc(); | ||
| return 0; |
|
This is again the wrong location for a fix and should be moved to the frontend. Like I did in #13446 previously. |
kinke
added a commit
to kinke/dmd
that referenced
this pull request
Apr 30, 2022
kinke
added a commit
to kinke/dmd
that referenced
this pull request
Apr 30, 2022
kinke
added a commit
to kinke/dmd
that referenced
this pull request
Apr 30, 2022
dlang-bot
pushed a commit
that referenced
this pull request
May 1, 2022
ibuclaw
pushed a commit
that referenced
this pull request
May 5, 2022
thewilsonator
pushed a commit
to thewilsonator/dmd
that referenced
this pull request
May 26, 2022
thewilsonator
pushed a commit
to thewilsonator/dmd
that referenced
this pull request
May 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… inside function