Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue 22967 - no return ref inference for extended return semantics #13952

Merged
merged 1 commit into from
Apr 6, 2022

Conversation

dkorpel
Copy link
Contributor

@dkorpel dkorpel commented Apr 5, 2022

#13940 introduced proper 'extended return semantics' (returning by assigning to this / the first ref parameter) for return ref, but it didn't have inference yet unlike return scope (#9220).

@dkorpel dkorpel added the dip1000 memory safety with scope, ref, return label Apr 5, 2022
@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @dkorpel! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
22967 enhancement [dip1000] no return ref inference for extended return semantics

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#13952"

@dkorpel dkorpel force-pushed the ref-assign-inference branch from f3519cc to 13012b8 Compare April 5, 2022 21:16
@RazvanN7 RazvanN7 merged commit 2f2594d into dlang:master Apr 6, 2022
@dkorpel dkorpel deleted the ref-assign-inference branch April 6, 2022 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dip1000 memory safety with scope, ref, return Severity:Enhancement
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants