Fix issue 23000 - final switch error has no line number with -checkaction=C #13971
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
assert(0)
for the default case of the final switch is generated in statementsem.d:Then in e2ir.d, the location of the assert expression is used, which is
IntegerExp.literal!0
in this case, which doesn't have a location set. This patch makes it use the location of the statement instead, which is actually consistent with the othercheckaction
s since a Dassert
also uses the location of the statement.I tested this manually, but not sure how to add this to the test suite because I can't
catch
a C assert, and I'm not sure we even want a new runnable test for something trivial like this, but I'm open to suggestions.