Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix Issue 23038 - importC: sizeof inside struct has struct members in… #14021

Merged
merged 1 commit into from
Apr 25, 2022
Merged

fix Issue 23038 - importC: sizeof inside struct has struct members in… #14021

merged 1 commit into from
Apr 25, 2022

Conversation

WalterBright
Copy link
Member

… scope

@WalterBright WalterBright added the Feature:ImportC Pertaining to ImportC support label Apr 22, 2022
@WalterBright WalterBright requested a review from Geod24 as a code owner April 22, 2022 22:27
@dlang-bot
Copy link
Contributor

dlang-bot commented Apr 22, 2022 •
edited
Loading

Thanks for your pull request, @WalterBright!

Bugzilla references

Auto-close Bugzilla Severity Description
✓ 23038 minor importC: sizeof inside struct has struct members in scope

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "stable + dmd#14021"

@ibuclaw
Copy link
Member

ibuclaw commented Apr 23, 2022

As this is a bug fix - and 2.100-beta has been tagged - this should target stable.

@RazvanN7 RazvanN7 changed the base branch from master to stable April 25, 2022 12:52
@dlang-bot dlang-bot merged commit c0cff59 into dlang:stable Apr 25, 2022
@WalterBright WalterBright deleted the fix23038 branch April 25, 2022 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RazvanN7 RazvanN7 RazvanN7 approved these changes

@Geod24 Geod24 Awaiting requested review from Geod24 Geod24 is a code owner

Assignees
No one assigned
Labels
Feature:ImportC Pertaining to ImportC support Merge:auto-merge Severity:Bug Fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@WalterBright @dlang-bot @ibuclaw @RazvanN7