Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix Issue 23044 - importC: comma expression with function call parsed… #14023

Merged
merged 1 commit into from
Apr 25, 2022

Conversation

WalterBright
Copy link
Member

… as declaration

My attempt to parse C without a symbol table is a complete failure.

@WalterBright WalterBright added the Feature:ImportC Pertaining to ImportC support label Apr 23, 2022
@WalterBright WalterBright requested a review from ibuclaw as a code owner April 23, 2022 07:05
@dlang-bot
Copy link
Contributor

dlang-bot commented Apr 23, 2022

Thanks for your pull request, @WalterBright!

Bugzilla references

Auto-close Bugzilla Severity Description
23044 normal importC: comma expression with function call parsed as declaration

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "stable + dmd#14023"

@WalterBright WalterBright force-pushed the fix23044 branch 3 times, most recently from 7a4d5a6 to 05a5413 Compare April 23, 2022 07:41
@ibuclaw
Copy link
Member

ibuclaw commented Apr 23, 2022

As this is a bug fix - and 2.100-beta has been tagged - this should target stable.

@RazvanN7 RazvanN7 changed the base branch from master to stable April 25, 2022 12:38
@RazvanN7 RazvanN7 merged commit 20ced85 into dlang:stable Apr 25, 2022
@WalterBright WalterBright deleted the fix23044 branch April 25, 2022 17:39
@MartinNowak MartinNowak mentioned this pull request May 3, 2022
ibuclaw pushed a commit that referenced this pull request May 5, 2022
@MartinNowak MartinNowak mentioned this pull request May 15, 2022
@ibuclaw ibuclaw mentioned this pull request May 15, 2022
thewilsonator pushed a commit to thewilsonator/dmd that referenced this pull request May 26, 2022
thewilsonator pushed a commit to thewilsonator/dmd that referenced this pull request May 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants