Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix Issue 23056 - importC: dmd asserts for missing return statement i… #14043

Merged
merged 1 commit into from
Apr 29, 2022

Conversation

WalterBright
Copy link
Member

…n CTFE function

@WalterBright WalterBright added Review:Easy Review Feature:ImportC Pertaining to ImportC support labels Apr 29, 2022
@dlang-bot
Copy link
Contributor

Thanks for your pull request, @WalterBright!

Bugzilla references

Auto-close Bugzilla Severity Description
23056 minor importC: dmd asserts for missing return statement in CTFE function

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#14043"

@ibuclaw
Copy link
Member

ibuclaw commented Apr 29, 2022

@WalterBright please target stable for these bug fixes.

@WalterBright
Copy link
Member Author

@ibuclaw I'm not so sure that's a good idea. This is new development, not regressions.

@thewilsonator
Copy link
Contributor

ICEs always go to stable, its not that hard.

@WalterBright WalterBright deleted the fix23056 branch April 30, 2022 05:24
@WalterBright
Copy link
Member Author

Many of our rules are in conflict.

@ibuclaw
Copy link
Member

ibuclaw commented Apr 30, 2022

It is especially important because we are cutting a new release in a couple weeks. This fix won't be in the 2.100 release because we've already merged master into stable last week, and won't do so again for another 2 months.

And as @thewilsonator says, if you can crash the compiler with some code, that is all the more reason to get it into the upcoming release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants