Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable] Move fix for issue 22974 from glue layer to frontend #14045

Merged
merged 1 commit into from
May 1, 2022

Conversation

kinke
Copy link
Contributor

@kinke kinke commented Apr 30, 2022

See #13950.

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @kinke! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
22974 normal importC: D name mangling applied to extern variable inside function

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "stable + dmd#14045"

@kinke
Copy link
Contributor Author

kinke commented Apr 30, 2022

Oh wait, I missed that the || vd.mangleOverride was added in the meantime.

@maxhaton
Copy link
Member

Oh wait, I missed that the || vd.mangleOverride was added in the meantime.

ok. Does that mean this isn't sufficiently covered by tests? If so could you add one (that would've caught this omission, if I follow correctly)

@kinke
Copy link
Contributor Author

kinke commented Apr 30, 2022

Looks like the test added in #14008 should cover it just fine. So I guess the if (d.mangleOverride) return null; is superfluous at the moment (for VarDecls).

Edit: Yep, mangle overrides are handled early in dmangle.d's Mangler, so I've changed it to an assertion.

@thewilsonator
Copy link
Contributor

This good to go? (Also cc @ibuclaw)

Copy link
Member

@ibuclaw ibuclaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, seems reasonable to me.

@dlang-bot dlang-bot merged commit a1a9ad8 into dlang:stable May 1, 2022
@kinke kinke deleted the move_fix22974 branch May 1, 2022 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants