-
-
Notifications
You must be signed in to change notification settings - Fork 610
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[stable] Move fix for issue 22974 from glue layer to frontend #14045
Conversation
|
Thanks for your pull request and interest in making D better, @kinke! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please see CONTRIBUTING.md for more information. If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment. Bugzilla references
Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "stable + dmd#14045" |
|
Oh wait, I missed that the |
ok. Does that mean this isn't sufficiently covered by tests? If so could you add one (that would've caught this omission, if I follow correctly) |
|
Looks like the test added in #14008 should cover it just fine. So I guess the Edit: Yep, mangle overrides are handled early in dmangle.d's |
|
This good to go? (Also cc @ibuclaw) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, seems reasonable to me.
See #13950.