Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default to -defaultlib= (no druntime/Phobos) for *.c tests #14056

Closed
wants to merge 1 commit into from

Conversation

kinke
Copy link
Contributor

@kinke kinke commented May 1, 2022

No description provided.

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @kinke! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#14056"

@@ -688,6 +688,10 @@ bool gatherTestParameters(ref TestArgs testArgs, string input_dir, string input_
if (testArgs.mode == TestMode.FAIL_COMPILE)
testArgs.requiredArgs = "-verrors=0 " ~ testArgs.requiredArgs;

// *.c tests: don't link druntime/Phobos
if (input_file.extension() == ".c")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

else if

Copy link
Contributor

@thewilsonator thewilsonator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise looks good.

@kinke
Copy link
Contributor Author

kinke commented May 1, 2022

DMD codegen doesn't look too good (this works with LDC; some importC tests are disabled though). __builtin_va_end is apparently no builtin but a druntime import, and TypeInfos seem to be emitted into the supposedly C object files too.

@maxhaton
Copy link
Member

maxhaton commented May 1, 2022

ImportC.h is in druntime and will presumably need to be tested at some point when preprocessing is more final.

@kinke
Copy link
Contributor Author

kinke commented May 2, 2022

@thewilsonator
Copy link
Contributor

#16818

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants