Fix Issue 23083 - .tupleof on static array rvalue evaluates expressio…

[pbackus]

…n multiple times

---

Targeting stable because this affects a newly-introduced language feature in 2.100.

[dlang-bot]

Thanks for your pull request and interest in making D better, @pbackus! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

• My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
• My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
• I have provided a detailed rationale explaining my changes
• New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.

---

If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close	Bugzilla	Severity	Description
✓	23083	normal	.tupleof on static array rvalue evaluates expression multiple times

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "stable + dmd#14068"

[kinke]

Not sure how that's possible (passing merge checks), but stable currently segfaults asserts for intel-intrinsics: https://buildkite.com/dlang/dmd/builds/26384#5fb8e990-1c9e-4a19-89cd-e46f9dbf5cdd

The same v1.10.1 (2 days old) works with master though: https://buildkite.com/dlang/dmd/builds/26388#996540d7-b1c2-4536-84e3-78df58793bc2

[pbackus]

The segfault is probably issue 23009, which was fixed in master by PR #13977 but didn't make the cutoff for stable.

Edit: never mind, I was confused because there are two copies of the commit, one in master (8f8b256) and one in stable (c19baac).

[kinke]

(merged eagerly; gdc 12 is to be released soon)