Call checkXXXescape functions without -dip1000 #14089
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request and interest in making D better, @dkorpel! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please see CONTRIBUTING.md for more information. If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment. Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "master + dmd#14089" |
dkorpel
force-pushed
the
enable-escape-checks
branch
from
5436488 to
d1f21a5
Compare
dkorpel
force-pushed
the
enable-escape-checks
branch
from
d1f21a5 to
fa4c770
Compare
dkorpel
force-pushed
the
enable-escape-checks
branch
from
fa4c770 to
b2f34ae
Compare
This was referenced May 10, 2022
dkorpel
force-pushed
the
enable-escape-checks
branch
from
b2f34ae to
80d84d2
Compare
dkorpel
force-pushed
the
enable-escape-checks
branch
2 times, most recently
from
728ad7d to
06c2af8
Compare
dkorpel
force-pushed
the
enable-escape-checks
branch
from
06c2af8 to
dbc7b9f
Compare
dkorpel
removed
Merge:Blocked
Review:WIP
|
@RazvanN7 this is finally green! |
RazvanN7
approved these changes
May 11, 2022
thewilsonator
pushed a commit
to thewilsonator/dmd
that referenced
this pull request
May 26, 2022
thewilsonator
pushed a commit
to thewilsonator/dmd
that referenced
this pull request
May 26, 2022
CyberShadow
added a commit
to CyberShadow/ae
that referenced
this pull request
May 29, 2023
The scope version is allowed with -preview=dip1000, or with DMD 2.101.0 or later (since dlang/dmd#14089).
CyberShadow
added a commit
to CyberShadow/ae
that referenced
this pull request
May 29, 2023
Use the signature of std.file.File.rawWrite. The scope version is allowed with -preview=dip1000, or with DMD 2.101.0 or later (since dlang/dmd#14089).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Doesn't pass yet, opening already to provide context for #14088