Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit 'address of ref' errors to safe code #14107

Merged
merged 1 commit into from
May 10, 2022

Conversation

dkorpel
Copy link
Contributor

@dkorpel dkorpel commented May 10, 2022

Returning the address of a ref variable is rejected even in @system code, even though it is allowed as soon as there is an intermediate assignment: #13993 (comment)

This inconsistency makes that adding return scope, which should strictly improve safety compared to a parameter without any scope annotations, can break @system code. This blocks #14100

@dkorpel dkorpel added the dip1000 memory safety with scope, ref, return label May 10, 2022
@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @dkorpel! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#14107"

Copy link
Member

@maxhaton maxhaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dkorpel dkorpel merged commit fa45b46 into dlang:master May 10, 2022
@dkorpel dkorpel deleted the setunsafe-checkreturnescape branch May 10, 2022 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dip1000 memory safety with scope, ref, return
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants