ImportC: automatically #include importc.h #14121
Conversation
|
Thanks for your pull request, @WalterBright! Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "master + dmd#14121" |
WalterBright
force-pushed
the
importc.h
branch
2 times, most recently
from
756f42a
to
e423061
Compare
| auto f = FileName.combine(entry, "importc.h"); | ||
| if (FileName.exists(f) == 1) | ||
| { | ||
| importc_h = f; |
There was a problem hiding this comment.
Where did you clean this? It is going to leak.
There was a problem hiding this comment.
FileName.combine() may or may not allocate memory, so it cannot be free'd.
There was a problem hiding this comment.
So you mean we may leak? What FileName.free() does? It seems bad design if we leak resources.
WalterBright
dismissed
ljmf00’s stale review
cannot free result of FileName.combine()
| foreach (entry; (global.path ? (*global.path)[] : null)) | ||
| { | ||
| auto f = FileName.combine(entry, "importc.h"); | ||
| if (FileName.exists(f) == 1) |
There was a problem hiding this comment.
I thought this would be redundant, but it turns out exists returns a magic number
| error("cannot find \"importc.h\" along import path"); | ||
| fatal(); |
|
Why is the burden placed on the callee of preprocess in order to find this header? |
Each preprocessor does it differently.