Fix Issue 23123 - -vasm ignored REX prefix for cmpxchg #14136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This led to a mistaken bug report because obj2asm has the same issue. The bug makes it look like dmd is emitting the wrong CAS instruction (but it actually was)
|
Thanks for your pull request, @maxhaton! Bugzilla references
Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "master + dmd#14136" |
thewilsonator
approved these changes
May 18, 2022
WalterBright
approved these changes
May 18, 2022
thewilsonator
pushed a commit
to thewilsonator/dmd
that referenced
this pull request
May 26, 2022
This led to a mistaken bug report because obj2asm has the same issue. The bug makes it look like dmd is emitting the wrong CAS instruction (but it actually was)
thewilsonator
pushed a commit
to thewilsonator/dmd
that referenced
this pull request
May 26, 2022
This led to a mistaken bug report because obj2asm has the same issue. The bug makes it look like dmd is emitting the wrong CAS instruction (but it actually was)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This led to a mistaken bug report because obj2asm has the same issue.
The bug makes it look like dmd is emitting the wrong CAS instruction (but it
actually was right)