Fix Issue 23170 - Array literal passed to map in lambda, then returne…

[dkorpel]

…d from nested function, is memory corrupted

This issue is already fixed in master by #14089, but @ibuclaw suggested backporting it to stable. Specifically, this part:

dmd/src/dmd/expressionsem.d

Lines 2050 to 2054 in 15d8805

	// Turning heap allocations into stack allocations is dangerous without dip1000, since `scope` inference
	// may be unreliable when scope violations only manifest as deprecation warnings.
	// However, existing `@nogc` code may rely on it, so still do it when the parameter is explicitly marked `scope`
	const explicitScope = (p.storageClass & STC.lazy_) ||
	((p.storageClass & STC.scope_) && !(p.storageClass & STC.scopeinferred));

[dlang-bot]

Thanks for your pull request and interest in making D better, @dkorpel! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

• My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
• My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
• I have provided a detailed rationale explaining my changes
• New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.

---

If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close	Bugzilla	Severity	Description
✓	23170	regression	Array literal passed to map in lambda, then returned from nested function, is memory corrupted

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "stable + dmd#14193"

[ibuclaw]

Many thanks for this @dkorpel!