Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 23169 - Mangling does not distinguish return and return scope #14233

Merged
merged 1 commit into from
Jun 22, 2022

Conversation

dkorpel
Copy link
Contributor

@dkorpel dkorpel commented Jun 21, 2022

No description provided.

@dkorpel dkorpel added the dip1000 memory safety with scope, ref, return label Jun 21, 2022
@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @dkorpel! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
23169 normal [DIP1000] Mangling does not distinguish return and return scope

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#14233"

@dkorpel dkorpel force-pushed the return-scope-mangle branch from 4b08afa to 5b0a960 Compare June 21, 2022 14:33
@dkorpel dkorpel marked this pull request as ready for review June 21, 2022 21:32
@thewilsonator thewilsonator added the Review:Needs Spec PR A PR updating the language specification needs to be submitted to dlang.org label Jun 22, 2022
Copy link
Member

@ljmf00 ljmf00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just update the ABI spec

@ljmf00
Copy link
Member

ljmf00 commented Jun 22, 2022

CC @ibuclaw can be updated on libiberty.

@dkorpel dkorpel removed the Review:Needs Spec PR A PR updating the language specification needs to be submitted to dlang.org label Jun 22, 2022
@dkorpel
Copy link
Contributor Author

dkorpel commented Jun 22, 2022

Just update the ABI spec

dlang/dlang.org#3325

@ibuclaw
Copy link
Member

ibuclaw commented Jun 22, 2022

CC @ibuclaw can be updated on libiberty.

The mangle parser is indiscriminate over what order attributes are layed out in.

@ljmf00
Copy link
Member

ljmf00 commented Jun 22, 2022

CC @ibuclaw can be updated on libiberty.

The mangle parser is indiscriminate over what order attributes are layed out in.

Ah right, makes sense.

@dlang-bot dlang-bot merged commit b524201 into dlang:master Jun 22, 2022
@dkorpel dkorpel deleted the return-scope-mangle branch June 22, 2022 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dip1000 memory safety with scope, ref, return Merge:auto-merge Severity:Bug Fix
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants