Fix Issue 23010 - mixed in aliaseqs used as type don't initialize #14237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request, @BorisCarvajal! Bugzilla references
Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "master + dmd#14237" |
|
It seems C++ header generation is better now using |
ibuclaw
reviewed
Jun 22, 2022
This is a no-op on my end. Incidentally I'm already doing the same as the added |
|
Moved some |
|
Dependant PR merged |
BorisCarvajal
force-pushed
the
fix23010
branch
2 times, most recently
from
d89c129 to
b98cd4c
Compare
`TupleDeclaration` elements were inserted to the `members` array of current `ScopeDsymbol` but `TemplateMixin` declarations are already expanded in statement level and this confused DMD backend. After adding some code to insert tuple elements to `AggregateDeclaration.fields` and for parsing tuples in `toObjFile`, the code in question can be removed. No more hidden symbols (like `__tuple_field_0`) inside any `members` field.
thewilsonator
approved these changes
Jun 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TupleDeclarationelements were inserted to themembersarray ofcurrent
ScopeDsymbolbutTemplateMixindeclarations are alreadyexpanded in statement level and this confused DMD backend.
After adding some code to insert tuple elements to
AggregateDeclaration.fieldsand for parsing tuples in
toObjFile, the code in question can be removed.No more hidden symbols (like
__tuple_field_0) inside anymembersfield.