Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add predefined version D_Optimized when compiling with -O #14245

Merged
merged 2 commits into from
Oct 5, 2022

Conversation

kinke
Copy link
Contributor

@kinke kinke commented Jun 23, 2022

So that code can be aware of whether it's compiled with -O, e.g., to distinguish between debug and optimized release builds (not necessarily using -release).

Rationale: https://dlang.slack.com/archives/C1ZDHBB2S/p1655556068067789

I'd have use for it for optimized druntime/Phobos unittests with LDC as well, where I've so far had to work around benign failures with -O by either preventing optimizations for unittest blocks/test helper functions (via @optStrategy("none")), or disabling some checks altogether.

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @kinke! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#14245"

@kinke kinke marked this pull request as ready for review June 23, 2022 18:15
@kinke kinke added Review:Needs Approval Review:Needs Spec PR A PR updating the language specification needs to be submitted to dlang.org labels Jun 23, 2022
@maxhaton
Copy link
Member

I am basically in favour of this.

@RazvanN7
Copy link
Contributor

RazvanN7 commented Jul 4, 2022

cc @WalterBright

@kinke
Copy link
Contributor Author

kinke commented Sep 17, 2022

Ping @WalterBright.

@RazvanN7
Copy link
Contributor

@kinke let's just move on with this. Resolve the conflicts and I'll merge this.

kinke and others added 2 commits October 4, 2022 14:28
So that code can be aware of whether it's compiled with `-O`, e.g., to
distinguish between debug and optimized release builds (not necessarily
using `-release`).
Co-authored-by: Petar Kirov <petar.p.kirov@gmail.com>
@kinke
Copy link
Contributor Author

kinke commented Oct 4, 2022

@RazvanN7: Alright, rebased and spec PR added: dlang/dlang.org#3431

@thewilsonator thewilsonator removed the Review:Needs Spec PR A PR updating the language specification needs to be submitted to dlang.org label Oct 4, 2022
@RazvanN7 RazvanN7 merged commit c5337c8 into dlang:master Oct 5, 2022
@kinke kinke deleted the d_optimized branch October 5, 2022 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants