-
-
Notifications
You must be signed in to change notification settings - Fork 608
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add predefined version D_Optimized when compiling with -O
#14245
Conversation
|
Thanks for your pull request and interest in making D better, @kinke! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please see CONTRIBUTING.md for more information. If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment. Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "master + dmd#14245" |
|
I am basically in favour of this. |
|
Ping @WalterBright. |
|
@kinke let's just move on with this. Resolve the conflicts and I'll merge this. |
So that code can be aware of whether it's compiled with `-O`, e.g., to distinguish between debug and optimized release builds (not necessarily using `-release`).
Co-authored-by: Petar Kirov <petar.p.kirov@gmail.com>
|
@RazvanN7: Alright, rebased and spec PR added: dlang/dlang.org#3431 |
So that code can be aware of whether it's compiled with
-O, e.g., to distinguish between debug and optimized release builds (not necessarily using-release).Rationale: https://dlang.slack.com/archives/C1ZDHBB2S/p1655556068067789
I'd have use for it for optimized druntime/Phobos unittests with LDC as well, where I've so far had to work around benign failures with
-Oby either preventing optimizations for unittest blocks/test helper functions (via@optStrategy("none")), or disabling some checks altogether.