Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix Issue 23206 - ImportC: __declspec(noreturn) does not compile #14252

Merged
merged 1 commit into from
Jun 26, 2022

Conversation

WalterBright
Copy link
Member

Needed to compile <errno.h> in dlang/druntime#3856

@WalterBright WalterBright added Review:Easy Review Feature:ImportC Pertaining to ImportC support labels Jun 26, 2022
@WalterBright WalterBright requested a review from ibuclaw as a code owner June 26, 2022 01:20
@dlang-bot
Copy link
Contributor

Thanks for your pull request, @WalterBright!

Bugzilla references

Auto-close Bugzilla Severity Description
23206 major ImportC: __declspec(noreturn) does not compile

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#14252"

@dlang-bot dlang-bot merged commit 6ede0f5 into dlang:master Jun 26, 2022
@WalterBright WalterBright deleted the fix23206 branch June 26, 2022 02:01
@ibuclaw
Copy link
Member

ibuclaw commented Jun 26, 2022

Rather than having support in the parser, can't we just rewrite __declspec(A) into __attribute__((A)) with a macro in importc.h?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants