Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 18973, 9161 - TypeInfo generation does not account for @disable #14272

Merged
merged 2 commits into from
Jul 7, 2022

Conversation

Geod24
Copy link
Member

@Geod24 Geod24 commented Jul 7, 2022

This changes `overloadExactMatch` as all 14 usages of it are to find
functions that can later be called.

This changes `overloadExactMatch` as all 14 usages of it are to find
functions that can later be called.
@dlang-bot
Copy link
Contributor

dlang-bot commented Jul 7, 2022

Thanks for your pull request, @Geod24!

Bugzilla references

Auto-close Bugzilla Severity Description
9161 normal Linker error on linux if struct has @disabled ~this();
18973 minor @disable on const toHash causes unresolved symbol error

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#14272"

@Geod24 Geod24 changed the title Fix 18973 - TypeInfo generation does not account for @disable Fix 18973, 9161 - TypeInfo generation does not account for @disable Jul 7, 2022
@Geod24
Copy link
Member Author

Geod24 commented Jul 7, 2022

While looking at issues (I originally encountered this when working on a library), I also saw 9161 - Added a fix for it as well.

@Geod24 Geod24 requested a review from thewilsonator July 7, 2022 05:05
@RazvanN7 RazvanN7 self-requested a review July 7, 2022 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants