Fix Issue 22390 - Compiler crash when iterating empty array of bottom types

[RazvanN7]

I'm not sure this is the right fix. I tracked this down to the backend where the opcode for a specific jump is generated. Since noreturn is neither signed, nor unsigned I simply went with what is done for pointers.

cc @WalterBright .

[dlang-bot]

Thanks for your pull request and interest in making D better, @RazvanN7! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

• My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
• My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
• I have provided a detailed rationale explaining my changes
• New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.

---

If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close	Bugzilla	Severity	Description
✓	22390	critical	Compiler crash when iterating empty array of bottom types

⚠️⚠️⚠️ Warnings ⚠️⚠️⚠️

• Regression or critical bug fixes should always target the stable branch. Learn more about rebasing to stable or the D release process.

To target stable perform these two steps:

1. Rebase your branch to upstream/stable:

git rebase --onto upstream/stable upstream/master

2. Change the base branch of your PR to stable

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#14294"

[thewilsonator]

ICEs go to stable

[RazvanN7]

Firstly, I don't feet comfortable this going to stable. Secondly, this is currently needed to unblock dlang/phobos#8283 which is targeting master.

[Geod24]

Since .1 has just been tagged I think we can let this go to master. CC @ibuclaw

[dukc]

Secondly, this is currently needed to unblock dlang/phobos#8283 which is targeting master.

I'm not sure my trivial PR is worth to delay crash fixes like this one 😄 . Thanks anyway!

[WalterBright]

Code generation winds up instantiating the template core.array.equality, which attempts to generate code for it. But code for it makes no sense.

empty==empty should simply constant fold to true.

[WalterBright]

See my comment

[WalterBright]

Two arrays of noreturn should simply compare the lengths when doing an equality check.

[RazvanN7]

@WalterBright Thanks for the clarification. It does make sense to check the length in this situation. I have updated the code.