fix Issue 23249 - Deprecation: argument &p for format specification "%m" must be char*, not char** #14307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request, @ibuclaw! Bugzilla references
Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "master + dmd#14307" |
ibuclaw
commented
Jul 15, 2022
Luhrel
reviewed
Jul 16, 2022
|
Sorted out the implementation, the tests are yet to be updated. |
ibuclaw
force-pushed
the
issue23249
branch
4 times, most recently
from
55c6289 to
fe4f7f4
Compare
ibuclaw
commented
Jul 19, 2022
| @@ -27,48 +33,38 @@ void main() | |||
| #line 100 | |||
| printf("%m this is a string in errno"); | |||
| printf("%s %m", "str".ptr, 2); | |||
There was a problem hiding this comment.
Should the chkformat complain when there are more arguments than format specifiers @WalterBright?
…%m" must be char*, not char**
|
This is fine for now, fixing scansets will be next. |
thewilsonator
approved these changes
Jul 19, 2022
Luhrel
approved these changes
Jul 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Properly implement
%mextension. Still missing%m[xxx], but that is related to issue 23251.At this point, I'm not sure whether it would be better to hoist the printf and scanf-specific parsing into
parsePrintfFormatSpecifierandparseScanfFormatSpecifierrespectively - callingparseGenericFormatSpecifieronly if not handling any context-dependent formats.