Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix Issue 23262 - typesafe variadic function parameter cannot infer r… #14320

Merged
merged 1 commit into from
Jul 23, 2022

Conversation

WalterBright
Copy link
Member

…eturn

@dlang-bot
Copy link
Contributor

Thanks for your pull request, @WalterBright!

Bugzilla references

Auto-close Bugzilla Severity Description
23262 normal typesafe variadic function parameter cannot infer return

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#14320"

@WalterBright
Copy link
Member Author

Blocking #14319

@WalterBright
Copy link
Member Author

The buildkite error:

CMake Error at cmake/Modules/FindLLVM.cmake:64 (message):
--
  | No LLVM installation (>= 9.0) found.  Try manually setting the
  | 'LLVM_ROOT_DIR' or 'LLVM_CONFIG' variables.

Doesn't look relevant to this PR.

@WalterBright
Copy link
Member Author

@RazvanN7 the buildkite error is happening on other PRs. It's holding everything up.

@Geod24
Copy link
Member

Geod24 commented Jul 22, 2022

Workaround: dlang/ci#462

* Returns:
* true if `v` is a variadic parameter
*/
bool isTypesafeVariadicParameter(FuncDeclaration fd, VarDeclaration v)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this can be refactored to avoid writing code for the parameter finding logic again, but for this PR it's fine.

@WalterBright WalterBright merged commit 9991829 into dlang:master Jul 23, 2022
@WalterBright WalterBright deleted the fix23262 branch July 23, 2022 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Review:Blocking Other Work review and pulling should be a priority Severity:Bug Fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants