-
-
Notifications
You must be signed in to change notification settings - Fork 610
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix Issue 23262 - typesafe variadic function parameter cannot infer r… #14320
Conversation
|
Thanks for your pull request, @WalterBright! Bugzilla references
Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "master + dmd#14320" |
|
Blocking #14319 |
|
The buildkite error: Doesn't look relevant to this PR. |
|
@RazvanN7 the buildkite error is happening on other PRs. It's holding everything up. |
|
Workaround: dlang/ci#462 |
| * Returns: | ||
| * true if `v` is a variadic parameter | ||
| */ | ||
| bool isTypesafeVariadicParameter(FuncDeclaration fd, VarDeclaration v) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this can be refactored to avoid writing code for the parameter finding logic again, but for this PR it's fine.
…eturn