Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 23022 - typesafe variadic parameter should not infer return #14327

Merged
merged 2 commits into from
Jul 25, 2022

Conversation

dkorpel
Copy link
Contributor

@dkorpel dkorpel commented Jul 25, 2022

Branched off #14326 because it uses the new signature of isTypesafeVariadicParameter

@dkorpel dkorpel added the dip1000 memory safety with scope, ref, return label Jul 25, 2022
@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @dkorpel! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
23022 normal [dip1000] typesafe variadic parameter should not infer return

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#14327"

@dkorpel dkorpel merged commit b9ee361 into dlang:master Jul 25, 2022
@dkorpel dkorpel deleted the return-typesafe-variadic branch July 25, 2022 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dip1000 memory safety with scope, ref, return Merge:auto-merge Severity:Bug Fix
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants