Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Issue 23271 - Mark lowered DeclExps in array appends as exptemp #14328

Merged
merged 1 commit into from
Jul 26, 2022
Merged

Fix Issue 23271 - Mark lowered DeclExps in array appends as exptemp #14328

merged 1 commit into from
Jul 26, 2022

Conversation

maxhaton
Copy link
Member

No description provided.

@dlang-bot
Copy link
Contributor

Thanks for your pull request, @maxhaton!

Bugzilla references

Auto-close Bugzilla Severity Description
✓ 23271 regression `goto` skips declaration of variable `bugred.A.test.__appendtmp4`

⚠️⚠️⚠️ Warnings ⚠️⚠️⚠️

To target stable perform these two steps:

  1. Rebase your branch to upstream/stable:
git rebase --onto upstream/stable upstream/master
  1. Change the base branch of your PR to stable

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#14328"

@adamdruppe
Copy link
Contributor

remarkable

RazvanN7
RazvanN7 approved these changes Jul 25, 2022
View reviewed changes
Copy link
Contributor

@RazvanN7 RazvanN7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stable please

@maxhaton
Copy link
Member Author

Stable please

The thing that regressed isn't in stable yet as far as I can see

@RazvanN7 RazvanN7 merged commit 0f2c2e8 into dlang:master Jul 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RazvanN7 RazvanN7 RazvanN7 approved these changes

@thewilsonator thewilsonator thewilsonator approved these changes

Assignees
No one assigned
Labels
Severity:Bug Fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@maxhaton @dlang-bot @adamdruppe @thewilsonator @RazvanN7