Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 20823 - un-@safe code fails with dip1000 #14331

Merged
merged 1 commit into from
Jul 26, 2022

Conversation

dkorpel
Copy link
Contributor

@dkorpel dkorpel commented Jul 25, 2022

It works now, simply add the test case

@dkorpel dkorpel added the dip1000 memory safety with scope, ref, return label Jul 25, 2022
@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @dkorpel! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
20823 normal [DIP 1000] un-@safe code fails with dip1000

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#14331"

@RazvanN7 RazvanN7 merged commit d7772a2 into dlang:master Jul 26, 2022
@dkorpel dkorpel deleted the dip1000-unsafe-code branch August 27, 2023 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dip1000 memory safety with scope, ref, return Severity:Bug Fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants