Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Infer template this parameter when calling static method on instance #14446

Merged
merged 2 commits into from
Sep 26, 2022

Conversation

ntrel
Copy link
Contributor

@ntrel ntrel commented Sep 16, 2022

Part of Issue 10488 - Allow template this parameter with static functions.

Note: The test is based on code by @tgehr.

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @ntrel! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
10488 enhancement Allow template this parameter to work with static functions

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#14446"

Part of Issue 10488 - Allow template this parameter with static functions.
compiler/test/compilable/statictemplatethis.d Outdated Show resolved Hide resolved
compiler/src/dmd/dtemplate.d Outdated Show resolved Hide resolved
Co-authored-by: Dennis <dkorpel@users.noreply.github.com>
@ntrel ntrel closed this Sep 24, 2022
@ntrel ntrel reopened this Sep 24, 2022
@RazvanN7 RazvanN7 merged commit 9777994 into dlang:master Sep 26, 2022
@ntrel ntrel deleted the static-this-param branch October 1, 2022 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants