Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Issue 13732 - non-member templates can use "template this" #14447

Closed
wants to merge 1 commit into from

Conversation

ntrel
Copy link
Contributor

@ntrel ntrel commented Sep 16, 2022

Error if a TemplateThisParameter is declared where typeof(this) would be an error.
Error if a TemplateThisParameter is passed a type that doesn't implicitly convert to const typeof(this).

Note: This is done with a dummy specialization, which triggers the semantic error messages even for a template mixin and may be more efficient than doing the check in dtemplate.d.

Explicitly overriding the specialization is supported for now, but even then this T should implicitly convert to const typeof(this).

Error if a TemplateThisParameter is declared where `typeof(this)` would
be an error.
Error if a TemplateThisParameter is passed a type that doesn't convert
to `const typeof(this)`.

Note: This is done with a dummy specialization, which causes the correct
semantic error messages even for mixin and may be more efficient than
checking this in dtemplate.d.
@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @ntrel! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
13732 normal Regular templates can use "template this", and they allow any type to be passed

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#14447"

@ntrel
Copy link
Contributor Author

ntrel commented Sep 16, 2022

This doesn't work because of shared :-/

@ntrel ntrel closed this Sep 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants