fix Issue 23348 - not handling braceless sub structs in initializers #14455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request, @WalterBright! Bugzilla references
Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "master + dmd#14455" |
RazvanN7
reviewed
Sep 19, 2022
| @@ -727,7 +727,7 @@ extern(C++) Initializer initializerSemantic(Initializer init, Scope* sc, ref Typ | |||
| * index = index into ci.initializer, updated | |||
| * Returns: struct initializer for this substruct | |||
| */ | |||
| Initializer subStruct(TypeStruct ts, ref size_t index) | |||
| Initializer subStruct()(TypeStruct ts, ref size_t index) | |||
There was a problem hiding this comment.
Why is this being turned into a template?
There was a problem hiding this comment.
subStruct() is turned into a template so it can forward reference subArray()
RazvanN7
approved these changes
Sep 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix another gap in the initializer handling.
subStruct()is turned into a template so it can forward referencesubArray().