fix Issue 22674 - ImportC: compatible types declared in different tra… #14461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request, @WalterBright! Bugzilla references
Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "master + dmd#14461" |
WalterBright
force-pushed
the
fix22674
branch
from
7d4b616
to
25ba3f6
Compare
WalterBright
force-pushed
the
fix22674
branch
from
25ba3f6
to
ab24cd2
Compare
WalterBright
force-pushed
the
fix22674
branch
2 times, most recently
from
f0abf8d
to
b097250
Compare
…nslation units are not treated equivalent in D
WalterBright
force-pushed
the
fix22674
branch
from
b097250
to
b9c117f
Compare
maxhaton
reviewed
Sep 21, 2022
maxhaton
approved these changes
Sep 21, 2022
|
I wish you'd wait until we have a chance to actually test it before merging. This didn't actually fix the issue listed and if you could have let us test it, we would have told you that. I came down with a nasty surprise flu and it put me behind schedule on code work but still, there shouldn't have been a rush to merge. |
maxhaton
pushed a commit
to maxhaton/dmd
that referenced
this pull request
Sep 24, 2022
…nslation units are not treated equivalent in D (dlang#14461)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…nslation units are not treated equivalent in D
This fix seems too easy. Let's see how it works.